[PATCH] D116462: [SPIRV 3/6] Add MC layer, object file support and InstPrinter

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.

LGTM with a nit



================
Comment at: llvm/lib/MC/MCSPIRVStreamer.cpp:23
+  SmallVector<MCFixup, 0> Fixups;
+  SmallString<512> Code;
+  raw_svector_ostream VecOS(Code);
----------------
Seems like a surprisingly big small size


================
Comment at: llvm/lib/Target/SPIRV/MCTargetDesc/SPIRVMCCodeEmitter.cpp:90
+  } else {
+    llvm_unreachable("Error: Unexpected operand type in VReg");
+  }
----------------
No Error: 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116462/new/

https://reviews.llvm.org/D116462