[PATCH] D121972: Add cmake/ to release tarballs via concatenation

Konrad Wilhelm Kleine via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 21 05:09:10 PDT 2022


kwk added a comment.

In D121972#3393048 <https://reviews.llvm.org/D121972#3393048>, @Ericson2314 wrote:

> `git archive --help` says:
>
>>   <path>
>>       Without an optional path parameter, all files and subdirectories of the
>>       current working directory are included in the archive. If one or more paths
>>       are specified, only these are included.
>
> so perhaps we should consider just doing something like that? if a two directory tarbomb is no good, we can add another layer of nesting?

This won't work because it will pack the `cmake` next to the content of `compiler-rt`. This can cause unexpected overwrites because there already is a `cmake` directory inside of `compiler-rt`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121972/new/

https://reviews.llvm.org/D121972



More information about the llvm-commits mailing list