[PATCH] D121554: [mlir][OpenMP] Added translation from `omp.atomic.capture` to LLVM IR

Alex Zinenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 21 02:24:07 PDT 2022


ftynse accepted this revision.
ftynse added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1166
+      moduleTranslation.lookupValue(atomicCaptureOp.getAtomicReadOp().v());
+  LLVM::LLVMPointerType mlirXType = atomicCaptureOp.getAtomicReadOp()
+                                        .x()
----------------
Optional nit: the RHS expression ending by a `cast` is a legit case for using `auto` (inferred type is obvious from local context).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121554/new/

https://reviews.llvm.org/D121554



More information about the llvm-commits mailing list