[PATCH] D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2]

[Chris Jackson via Phabricator via llvm-commits]

chrisjackson updated this revision to Diff 416860.
chrisjackson added a comment.

A WIP update only, not ready for a re-review. Incorporated some of @StephenTozer 's suggestions e.g.

- replacing densemap with vector (though this still needs to be done for the location-op index)
- making use of unique_ptr, though this had some knock-on effects on other structures -Simplified a branch in UpdateDbgValueInst

There are still several changes to make, including restoring the pre-LSR cached dbg.value correctly. I have observed that some passes will create DIArgList with a single location. This is valid, but it means extra case-handling is necessary, as the number of location-ops does not indicate the absence or presence of DIArgList, the presence of which does effect the validity of the DIExpression.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120169/new/

https://reviews.llvm.org/D120169

Files:
  llvm/include/llvm/Analysis/ScalarEvolution.h
  llvm/lib/Analysis/ScalarEvolution.cpp
  llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp
  llvm/test/Transforms/LoopStrengthReduce/debuginfo-scev-salvage-5.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D120169.416860.patch
Type: text/x-patch
Size: 27568 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220321/a9bd78b9/attachment.bin>