[PATCH] D122082: Add DXIL Bitcode Writer and DXIL testing

Sun Mar 20 02:02:18 PDT 2022

nikic added a comment.

In D122082#3394675 <https://reviews.llvm.org/D122082#3394675>, @beanz wrote:

> In D122082#3394525 <https://reviews.llvm.org/D122082#3394525>, @nikic wrote:
>
>> This implementation is not compatible with opaque pointers (https://llvm.org/docs/OpaquePointers.html) and will likely need a significant rework to support them.
>
> I don’t disagree, but…
>
> Much of this code will work just fine with opaque pointers, and opaque pointers aren’t fully supported in clang (the only frontend we’re trying to support).
>
> Since this code is going into an experimental backend, does opaque pointer support need to block this from landing, or can that be addressed subsequently?

Yes, opaque pointer support is a hard requirement for any new code introduced in LLVM. Of course, it's okay if you implement it in a separate patch from this one, it just needs to be part of the patch stack and land at the same time.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122082/new/

https://reviews.llvm.org/D122082