[PATCH] D122082: Add DXIL Bitcode Writer and DXIL testing

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

See https://discourse.llvm.org/t/opaque-pointers-status-update/60296 for the current status of opaque pointers.



================
Comment at: llvm/include/llvm/Bitcode/BitcodeWriter.h:37
+    bool ShouldPreserveUseListOrder, const ModuleSummaryIndex *Index,
+    bool GenerateHash, ModuleHash *ModHash);
+class BitcodeWriter {
----------------
Instead of returning a unique_ptr to an object that has exactly one function called on it, can you just pass in a callback function that constructs the writer and calls write()?


================
Comment at: llvm/include/llvm/Bitcode/BitcodeWriter.h:38
+    bool GenerateHash, ModuleHash *ModHash);
+class BitcodeWriter {
+  SmallVectorImpl<char> &Buffer;
----------------
Please land the whitespace change here separately.


================
Comment at: llvm/lib/Bitcode/Writer/BitcodeWriterPass.cpp:1
 //===- BitcodeWriterPass.cpp - Bitcode writing pass -----------------------===//
 //
----------------
BitcodeWriterPass is a tiny amount of code... you might as well just fork it.  (Normally, I'd be in favor of trying to share more code, but I'd prefer to minimize the changes to target-independent code for now.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122082/new/

https://reviews.llvm.org/D122082