[PATCH] D122071: [SDAG] enable binop identity constant folds for multiplies

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 19 08:49:42 PDT 2022


RKSimon created this revision.
RKSimon added reviewers: LuoYuanke, craig.topper, pengfei, spatel, lebedev.ri.
Herald added subscribers: ecnelises, hiraditya.
Herald added a project: All.
RKSimon requested review of this revision.
Herald added a project: LLVM.

Add mul to the list of ops that we canonicalize with a select to expose an identity merge

@lebedev.ri I'm not familiar with the midpoint vector tests - your comments on rGc38831e11dc33d2a83 <https://reviews.llvm.org/rGc38831e11dc33d2a8325ee6ada9827cff0396945> suggest the vector tests were just for completeness, but the simplification in codegen suggests there might be additional missing DAG folds ?


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D122071

Files:
  llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  llvm/test/CodeGen/X86/midpoint-int-vec-128.ll
  llvm/test/CodeGen/X86/midpoint-int-vec-256.ll
  llvm/test/CodeGen/X86/midpoint-int-vec-512.ll
  llvm/test/CodeGen/X86/vector-bo-select.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D122071.416704.patch
Type: text/x-patch
Size: 164134 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220319/cc3e0bca/attachment.bin>


More information about the llvm-commits mailing list