[PATCH] D121982: [Xcore] Set Int_MemBarrier as a meta-instruction

[Kan Shengchen via Phabricator via llvm-commits]

skan added a comment.

In D121982#3392172 <https://reviews.llvm.org/D121982#3392172>, @nigelp-xmos wrote:

> As the test is specifying targets, I think it needs to be in both X86 and XCore areas. Otherwise compilers not supporting those targets will attempt the test.
>
> There is "REQUIRES: ...-registered-target" (for example in attr-btf_tag.ll) but I think "REQUIRES: x86-registered-target,xcore-registered-target" would only test compilers supporting both targets, which is not right.
>
> I suppose an alternative to duplicating is a new REQUIRES name but perhaps that's excessive for one test, and duplicating is simplest?

Thanks! Good catch! I will do that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121982/new/

https://reviews.llvm.org/D121982