[PATCH] D121982: [Xcore] Set Int_MemBarrier as a meta-instruction
Nigel Perks via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 18 06:09:11 PDT 2022
nigelp-xmos added a comment.
As the test is specifying targets, I think it needs to be in both X86 and XCore areas. Otherwise compilers not supporting those targets will attempt the test.
There is "REQUIRES: ...-registered-target" (for example in attr-btf_tag.ll) but I think "REQUIRES: x86-registered-target,xcore-registered-target" would only test compilers supporting both targets, which is not right.
I suppose an alternative to duplicating is a new REQUIRES name but perhaps that's excessive for one test, and duplicating is simplest?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121982/new/
https://reviews.llvm.org/D121982
More information about the llvm-commits
mailing list