[PATCH] D120861: [XCOFF][1/3] support fileHeader and sectionHeaders in 64-bit XCOFF.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 18 13:17:46 PDT 2022


jhenderson accepted this revision.
jhenderson added a comment.

LGTM.



================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:299
   bool
   needsAuxiliaryHeader() const { /* TODO aux header support not implemented. */
     return false;
----------------
DiggerLin wrote:
> jhenderson wrote:
> > Put the TODO comment either on a new line within the function (as suggested inline), or immediately before it as a commetnt, using `//` rather than block comments, then use clang-format to reformat it appropriately.
> James ask for put the comment  within the function , not sure whether meet James comment.  @jhenderson 
I said either inside, or immediately before, so this is fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120861/new/

https://reviews.llvm.org/D120861



More information about the llvm-commits mailing list