[PATCH] D120861: [XCOFF][1/3] support fileHeader and sectionHeaders in 64-bit XCOFF.

Fri Mar 18 08:44:02 PDT 2022

DiggerLin accepted this revision.
DiggerLin added a comment.
This revision is now accepted and ready to land.

LGTM.
I do not have further comment, but  please wait for James approve.

================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:299
   bool
   needsAuxiliaryHeader() const { /* TODO aux header support not implemented. */
     return false;
----------------
jhenderson wrote:
> Put the TODO comment either on a new line within the function (as suggested inline), or immediately before it as a commetnt, using `//` rather than block comments, then use clang-format to reformat it appropriately.
James ask for put the comment  within the function , not sure whether meet James comment.  @jhenderson 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120861/new/

https://reviews.llvm.org/D120861