[PATCH] D121768: [tablgen][X86] Auto-generate trival fields and interace for target features

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 17 20:13:26 PDT 2022


craig.topper added a comment.

Every feature bit is exposed directly to FeatureBits vector at the MC layer using the name of the tablegen def. It is to our advantage to have consistent naming between the Def, the Subtarget field name, and the getter. Thus the concept of the getter being different than the Subtarget field doesn’t make sense because it means the MC layer is still wrong.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121768/new/

https://reviews.llvm.org/D121768



More information about the llvm-commits mailing list