[PATCH] D121768: [tablgen][X86] Auto-generate trival fields and interace for target features

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

The cmov mess is because SSE and 64-bit odegen assumes cmov exists. We couldn’t make 64-bit or SSE imply cmov feature or -mattr=-cmov would disable SSE or 64bit which is just completely broken. Thus the OR that ignores attempts to disable cmov.



================
Comment at: llvm/include/llvm/Target/Target.td:1647
+
+  // TrivalField - Auto-generate a trival field for this feature.
+  // A trival field is always zero-initialized.
----------------
Trival->Trivial


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121768/new/

https://reviews.llvm.org/D121768