[PATCH] D121722: [AlwaysInliner] Check inliner errors even without assserts

[Ellis Hoag via Phabricator via llvm-commits]

ellis added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/AlwaysInliner.cpp:80
+        BasicBlock *Block = CB->getParent();
+        emitInlinedIntoBasedOnCost(ORE, DLoc, Block, F, *Caller, *OIC, false,
+                                   DEBUG_TYPE);
----------------
kyulee wrote:
> Should it be moved down after InlineResult is successful?
> This is about remarking a success case which we want only when it succeeded.
Good catch. I've just uploaded D121946 to fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121722/new/

https://reviews.llvm.org/D121722