[PATCH] D121722: [AlwaysInliner] Check inliner errors even without assserts

Kyungwoo Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 17 10:29:10 PDT 2022


kyulee added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/AlwaysInliner.cpp:80
+        BasicBlock *Block = CB->getParent();
+        emitInlinedIntoBasedOnCost(ORE, DLoc, Block, F, *Caller, *OIC, false,
+                                   DEBUG_TYPE);
----------------
Should it be moved down after InlineResult is successful?
This is about remarking a success case which we want only when it succeeded.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121722/new/

https://reviews.llvm.org/D121722



More information about the llvm-commits mailing list