[PATCH] D121905: [AArch64][SVE] Fix lowering of "fcmp ueq/one" when using SVE

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1300
+      setCondCodeAction(ISD::SETONE, VT, Expand);
       setCondCodeAction(ISD::SETUNE, VT, Expand);
     }
----------------
dmgreen wrote:
> I'm not near a computer to do decent testing, but should SETUNE be expanded? It seems like it should become a fcmne, if I'm reading the pseudocode correctly. And the issue here is that SETUNE and SETONE were being treated backwards.
> 
> There are ISel patterns for FCMNE_PPzZZ and FCMNE_PPzZ0 that still try (but will never?) use SETONE. I think they can be using SETUNE though.
I was just typing the same thing after running some tests.  Yes, we should be able to change the existing patterns and just flip `U` to `O` for the two  `setCondCodeAction` calls.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121905/new/

https://reviews.llvm.org/D121905