[PATCH] D121914: [AMDGPU] Stop using getMinimalPhysRegClass in LowerFormalArguments

Joe Nash via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 17 08:21:32 PDT 2022


Joe_Nash added a comment.

As you say, it seems guaranteed to be SGPR or VGPR by the calling convention. They compile to the same thing under optimization right? If so I slightly prefer the llvm_unreachable version because the intent is locally clear.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121914/new/

https://reviews.llvm.org/D121914



More information about the llvm-commits mailing list