[PATCH] D121801: [llmv-pdbutil] Replace ExitOnError with explicit error handling.
Carlos Alberto Enciso via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 17 07:06:49 PDT 2022
CarlosAlbertoEnciso updated this revision to Diff 416167.
CarlosAlbertoEnciso added a comment.
- Added details about the intended second patch, that includes: files and functions being moved into the PDB library.
- Replaced the 'auto' for the specific: Expected<DbiStream &> and DbiStream.
- Added an early exit.
The only remainding comment not addressed is from @aganea, in relation to the
ExitOnError Err("Unexpected error processing modules: ");
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121801/new/
https://reviews.llvm.org/D121801
Files:
llvm/tools/llvm-pdbutil/DumpOutputStyle.cpp
llvm/tools/llvm-pdbutil/InputFile.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D121801.416167.patch
Type: text/x-patch
Size: 19391 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220317/432b8eba/attachment.bin>
More information about the llvm-commits
mailing list