[PATCH] D121801: [llmv-pdbutil] Replace ExitOnError with explicit error handling.

Carlos Alberto Enciso via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 17 05:10:22 PDT 2022


CarlosAlbertoEnciso added a comment.

As stated, we intend to move some functionality into the PDB library:

Patch (1) Replace 'ExitOnError' with explicit error handling.
Patch (2) Move the intended shared code to the PDB library.

With the moved functionality, we are able to:

- Open a PDB file.
- Get module debug stream.
- Traverse module sections.
- Traverse module subsections.

The second patch only moves InputFile.cpp[h], LinePrinter.cpp[h] and
FormatUtil.cpp[h] files.

Most of the needed functionality is in InputFile, but there are
dependencies from LinePrinter and FormatUtil.

Some other functionality is in DumpOutputStyle.cpp file:

- iterateModuleSubsections
- getModuleDebugStream
- iterateOneModule
- iterateSymbolGroups
- iterateModuleSubsections

Only these specific functions from DumpOutputStyle are moved to the
PDB library.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121801/new/

https://reviews.llvm.org/D121801



More information about the llvm-commits mailing list