[llvm] 1dbeb64 - [SLP] Avoid unnecessary getIncomingValueForBlock() call (NFC)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 17 04:25:19 PDT 2022


Author: Nikita Popov
Date: 2022-03-17T12:23:46+01:00
New Revision: 1dbeb64493c4d3b21c4e173c3915d127405a1cf1

URL: https://github.com/llvm/llvm-project/commit/1dbeb64493c4d3b21c4e173c3915d127405a1cf1
DIFF: https://github.com/llvm/llvm-project/commit/1dbeb64493c4d3b21c4e173c3915d127405a1cf1.diff

LOG: [SLP] Avoid unnecessary getIncomingValueForBlock() call (NFC)

This code just wants to check all incoming values, we don't care
care what the incoming block is here.

Added: 
    

Modified: 
    llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp b/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
index 90114f934fcaa..48382a12fcf3c 100644
--- a/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
+++ b/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
@@ -4062,10 +4062,8 @@ void BoUpSLP::buildTree_rec(ArrayRef<Value *> VL, unsigned Depth,
 
       // Check for terminator values (e.g. invoke).
       for (Value *V : VL)
-        for (unsigned I = 0, E = PH->getNumIncomingValues(); I < E; ++I) {
-          Instruction *Term = dyn_cast<Instruction>(
-              cast<PHINode>(V)->getIncomingValueForBlock(
-                  PH->getIncomingBlock(I)));
+        for (Value *Incoming : cast<PHINode>(V)->incoming_values()) {
+          Instruction *Term = dyn_cast<Instruction>(Incoming);
           if (Term && Term->isTerminator()) {
             LLVM_DEBUG(dbgs()
                        << "SLP: Need to swizzle PHINodes (terminator use).\n");


        


More information about the llvm-commits mailing list