[PATCH] D120887: The [2/3] Fix mangle problem when variable used in inline asm (Add modifier P for ARR[BaseReg+IndexReg+..])

Xiang Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 16 17:21:42 PDT 2022


xiangzhangllvm added inline comments.


================
Comment at: llvm/lib/MC/MCParser/AsmParser.cpp:6158
+      if (AR.IntelExpRestricted)
+        OS << "${" << InputIdx++ << ":P}";
+      else
----------------
skan wrote:
> I think this is the first new usage of `P` here,  so you update the llvm/docs/LangRef.rst
Yes I am planning to, I'll update it in [3/3] patch. https://reviews.llvm.org/D121785


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120887/new/

https://reviews.llvm.org/D120887



More information about the llvm-commits mailing list