[PATCH] D120887: The [2/3] Fix mangle problem when variable used in inline asm (Add modifier P for ARR[BaseReg+IndexReg+..])

Kan Shengchen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 16 03:50:47 PDT 2022


skan added inline comments.


================
Comment at: llvm/lib/MC/MCParser/AsmParser.cpp:6158
+      if (AR.IntelExpRestricted)
+        OS << "${" << InputIdx++ << ":P}";
+      else
----------------
I think this is the first new usage of `P` here,  so you update the llvm/docs/LangRef.rst


================
Comment at: llvm/lib/Target/X86/AsmParser/X86Operand.h:72
+
+    /// This used for inlineasm which may specified base reg and index reg for
+    /// MemOp. e.g. ARR[eax + ecx*4], so no extra reg can be used for MemOp.
----------------
inline asm,  specify


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120887/new/

https://reviews.llvm.org/D120887



More information about the llvm-commits mailing list