[PATCH] D121566: Load pass plugins during option processing, so that plugin options are registered and live.

Tue Mar 15 20:14:02 PDT 2022

w2yehia added a subscriber: Meinersbur.
w2yehia added a comment.

@Meinersbur Hi Michael. I see this in polly's lit config file:

  config.substitutions.append(('%loadPolly', '-load '
                               + config.polly_lib_dir + '/LLVMPolly at LLVM_SHLIBEXT@'
                               + ' -load-pass-plugin '
                               + config.polly_lib_dir + '/LLVMPolly at LLVM_SHLIBEXT@'

The -load-pass-plugin was added in D45484 <https://reviews.llvm.org/D45484>, but the follow up change D45493 <https://reviews.llvm.org/D45493> never landed.
>From my understanding, -load and -load-pass-plugin are disjoint (one is for legacy PM and one for NPM) by design.
Since you cannot run both legacy and new PM, the only reason I think you need both `-load` and `-load-pass-plugin` is to be able to register polly's options before they're processed.
Which is the problem this PR addresses.
Should we remove `-load-pass-plugin` from `%loadPolly` for now, until polly switches to using NPM (i'm guessing it's using legacy PM because the new diagnostic i'm adding is being triggered by polly's tests) ?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121566/new/

https://reviews.llvm.org/D121566