[PATCH] D121566: Load pass plugins during option processing, so that plugin options are registered and live.

Tue Mar 15 05:59:04 PDT 2022

w2yehia added a comment.

I got many failures in poly. 
Seems it uses both `-load` and `-load-pass-plugin` with legacy PM passes?

Here's one:

  BUILD FAILED: failed 1054 unexpected failures (failure)

  Step 6 (check_polly) failure: 1054 unexpected failures (failure)
  ******************** TEST 'Polly :: ScheduleOptimizer/pattern-matching-based-opts_14.ll' FAILED ********************
  Script:
  --
  : 'RUN: at line 1';   /home/worker/buildbot-workers/polly-x86_64-gce1/rundir/llvm.obj/bin/opt -load /home/worker/buildbot-workers/polly-x86_64-gce1/rundir/llvm.obj/lib/LLVMPolly.so -load-pass-plugin /home/worker/buildbot-workers/polly-x86_64-gce1/rundir/llvm.obj/lib/LLVMPolly.so -polly-process-unprofitable  -polly-remarks-minimal  -polly-use-llvm-names  -polly-import-jscop-dir=/home/worker/src/llvm-project/polly/test/ScheduleOptimizer  -polly-codegen-verify  -polly-import-jscop -polly-opt-isl   -polly-target-throughput-vector-fma=1  -polly-target-latency-vector-fma=8  -polly-target-1st-cache-level-associativity=8  -polly-target-2nd-cache-level-associativity=8  -polly-target-1st-cache-level-size=32768  -polly-target-vector-register-bitwidth=256  -polly-target-2nd-cache-level-size=262144  -polly-import-jscop-postfix=transformed -polly-codegen -S < /home/worker/src/llvm-project/polly/test/ScheduleOptimizer/pattern-matching-based-opts_14.ll  | /home/worker/buildbot-workers/polly-x86_64-g
   ce1/rundir/llvm.obj/bin/FileCheck /home/worker/src/llvm-project/polly/test/ScheduleOptimizer/pattern-matching-based-opts_14.ll
  --
  Exit Code: 2

  Command Output (stderr):
  --
  /home/worker/buildbot-workers/polly-x86_64-gce1/rundir/llvm.obj/bin/opt: load-pass-plugin specified with legacy PM.
  FileCheck error: '<stdin>' is empty.
  FileCheck command line:  /home/worker/buildbot-workers/polly-x86_64-gce1/rundir/llvm.obj/bin/FileCheck /home/worker/src/llvm-project/polly/test/ScheduleOptimizer/pattern-matching-based-opts_14.ll

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121566/new/

https://reviews.llvm.org/D121566