[PATCH] D121696: [AMDGPU][MC][NFC] Refactored custom operands handling

[Dmitry Preobrazhensky via Phabricator via llvm-commits]

dp marked 2 inline comments as done.
dp added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/Utils/AMDGPUAsmUtils.h:29
+  int Encoding = 0;
+  bool (*Cond)(T Context) = nullptr;
+};
----------------
rampitec wrote:
> arsenm wrote:
> > Instead of a callback could you use a mask of required features?
> I believe it would need 3 masks then: required features 'and' mask, required features 'or' mask, and features required to be absent. Seems over-complicated to me.
Yes, I agree that it would be over-complicated (and less flexible). Also I wanted to use CustomOperand to simplify handling of message operations (OpSysSymbolic/OpGsSymbolic) which shall be enabled based on message id rather than on GPU features.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121696/new/

https://reviews.llvm.org/D121696