[PATCH] D121696: [AMDGPU][MC][NFC] Refactored custom operands handling
Stanislav Mekhanoshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 15 11:06:40 PDT 2022
rampitec accepted this revision.
rampitec added a comment.
This revision is now accepted and ready to land.
Thanks Dmitry!
================
Comment at: llvm/lib/Target/AMDGPU/Utils/AMDGPUAsmUtils.h:29
+ int Encoding = 0;
+ bool (*Cond)(T Context) = nullptr;
+};
----------------
arsenm wrote:
> Instead of a callback could you use a mask of required features?
I believe it would need 3 masks then: required features 'and' mask, required features 'or' mask, and features required to be absent. Seems over-complicated to me.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121696/new/
https://reviews.llvm.org/D121696
More information about the llvm-commits
mailing list