[PATCH] D120858: [NFC][XCOFF] Refactor and format XCOFFObjectWriter.cpp.

[Digger Lin via Phabricator via llvm-commits]

DiggerLin accepted this revision.
DiggerLin added a comment.

LGTM , but need to fix two comments.



================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:650
 void XCOFFObjectWriter::writeSymbolName(const StringRef &SymbolName) {
+  // Magic, Offset, SymbolName
   if (nameShouldBeInStringTable(SymbolName)) {
----------------
Nit:   // Magic, Offset or  SymbolName.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:827
+  // FIXME: add the real source file's name.
+  writeSymbolEntry(".file", /*Type=*/0, XCOFF::ReservedSectionNum::N_DEBUG,
+                   /*SymbolType=*/0, XCOFF::C_FILE,
----------------
 writeSymbolEntry(".file", /*Type=*/0, XCOFF::ReservedSectionNum::N_DEBUG, 

->
 writeSymbolEntry(".file", **/*Value=*/0,** XCOFF::ReservedSectionNum::N_DEBUG, 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120858/new/

https://reviews.llvm.org/D120858