[PATCH] D121510: [Support] Introduce the BLAKE3 hashing function implementation

Sat Mar 12 11:45:18 PST 2022

compnerd added a comment.

In D121510#3377285 <https://reviews.llvm.org/D121510#3377285>, @akyrtzi wrote:

> @compnerd the windows bot says
>
>   [110/8000] Building ASM object lib\Support\CMakeFiles\LLVMSupport.dir\BLAKE3\blake3_avx512_x86-64_windows_msvc.asm.obj
>   Microsoft (R) C/C++ Optimizing Compiler Version 19.29.30136 for x64
>   Copyright (C) Microsoft Corporation.  All rights reserved.
>   
>   cl : Command line warning D9035 : option 'o' has been deprecated and will be removed in a future release
>   cl : Command line warning D9024 : unrecognized source file type 'C:\ws\w32-1\llvm-project\premerge-checks\llvm\lib\Support\BLAKE3\blake3_avx512_x86-64_windows_msvc.asm', object file assumed
>   cl : Command line warning D9027 : source file 'C:\ws\w32-1\llvm-project\premerge-checks\llvm\lib\Support\BLAKE3\blake3_avx512_x86-64_windows_msvc.asm' ignored
>   cl : Command line warning D9021 : no action performed
>
> Do you have a hint what is going wrong, is the `.asm` file extension not correct for passing them to the compiler?

I think that you would need to do an `enable_language(ASM)` to have that be built properly, I don't think that we currently have any assembly routines in LLVM/clang and so that language has never been enabled.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121510/new/

https://reviews.llvm.org/D121510