[PATCH] D121510: [Support] Introduce the BLAKE3 hashing function implementation

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 12 11:41:57 PST 2022


MaskRay added a comment.

I am in favor of adding BLAKE3.

In D121510#3377292 <https://reviews.llvm.org/D121510#3377292>, @lebedev.ri wrote:

> The patch's description what this does, but now //why// it does what it does.

I can provide one rationale: speed up `ld.lld --build-id`: D121531 <https://reviews.llvm.org/D121531> :)

BLAKE3 can replace several places llvm-project uses `llvm::SHA1`, e.g. Clang PCH serialization, bold.
It's possible that we can just drop llvm/Support/SHA1.h after these call sites migrate away.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121510/new/

https://reviews.llvm.org/D121510



More information about the llvm-commits mailing list