[PATCH] D121394: [HWASan] Update use-after-scope test to use ARM64.

Thu Mar 10 18:42:37 PST 2022

hctim added a comment.

In D121394#3374071 <https://reviews.llvm.org/D121394#3374071>, @fmayer wrote:

> This is a auto-generated golden test: ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
>
> I think there is a value in that, to make sure any changes don't exceed the intended scope. There are more focused tests as well in this directory.

Maybe I'm just biased against golden-file tests like this because they're almost impossible to review (apart from "I trust the author"), and they increase churn significantly when one wants to make instrumentation changes. But, I do agree there's some value in the "didn't mess things up" check.

If that's all we're aiming for, would it make sense to have `use-after-scope-arm64.ll` and `use-after-scope-x64.ll`?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121394/new/

https://reviews.llvm.org/D121394