[PATCH] D121394: [HWASan] Update use-after-scope test to use ARM64.

Florian Mayer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 10 15:41:18 PST 2022


fmayer added a comment.

In D121394#3374029 <https://reviews.llvm.org/D121394#3374029>, @hctim wrote:

> This test is really hard to validate changes to. I mean, it's basically "$COMPILER produces $BLOB", right? I'm not really sure what are the interesting parts I'm supposed to be looking for.
>
> Is it possible to reduce the test to check the actual conditions?
>
> Like, for `standard_lifetime`, we have lifetime start -> shadow setup (some minimal UID like __hwasan_generate_tag) -> lifetime end -> shadow teardown (some minimal UID like memset-zero).

This is a auto-generated golden test: ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py

I think there is a value in that, to make sure any changes don't exceed the intended scope. There are more focused tests as well in this directory.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121394/new/

https://reviews.llvm.org/D121394



More information about the llvm-commits mailing list