[PATCH] D121396: Fix dsymutil to handle universal files that exceed 4GB.
Greg Clayton via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 10 14:07:49 PST 2022
clayborg added a comment.
In D121396#3373462 <https://reviews.llvm.org/D121396#3373462>, @JDevlieghere wrote:
> I prefer the way the other patch deals with non-fat Mach-O files. For fat binaries, we should iterate over the temp files and calculate the sum of the size and error out unless the final slice has an offset < UINT32_MAX. For example, having 3 architectures that are 1.5GB each is fine because the last slice starts at 3GB even though the final binary will be 4.5GB, but having 4 slices won't work.
So this code needs to be removed then right as part of the other patch?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121396/new/
https://reviews.llvm.org/D121396
More information about the llvm-commits
mailing list