[PATCH] D121396: Fix dsymutil to handle universal files that exceed 4GB.

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere requested changes to this revision.
JDevlieghere added a comment.
This revision now requires changes to proceed.

I prefer the way the other patch deals with non-fat Mach-O files. For fat binaries, we should iterate over the temp files and calculate the sum of the size and error out unless the final slice has an offset < UINT32_MAX. For example, having 3 architectures that are 1.5GB each is fine because the last slice starts at 3GB even though the final binary will be 4.5GB, but having 4 slices won't work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121396/new/

https://reviews.llvm.org/D121396