[PATCH] D120455: [CommandLine] Remove `may only occur zero or one times!` error

[Eric Christopher via llvm-commits]

On Thu, Mar 10, 2022 at 12:25 AM Fangrui Song via Phabricator <
reviews at reviews.llvm.org> wrote:

> MaskRay added a comment.
>
> In D120455#3355507 <https://reviews.llvm.org/D120455#3355507>, @ab wrote:
>
> > In D120455#3352886 <https://reviews.llvm.org/D120455#3352886>,
> @dexonsmith wrote:
> >
> >> I don't have a strong opinion; IMO `-mllvm` options shouldn't get used
> (except by compiler developers) since they're unstable, although I'm sure
> they get used a little anyway. IMO, if this makes it easier for the
> intended users (compiler developers) then there isn't a real downside to it.
> >>
> >> @ab @t.p.northover @Gerolf , any thoughts from you?
> >
> > Yeah, this seems reasonable, but no strong opinions either.  I totally
> empathize with the concerns, and ideally we wouldn't have all this exposed
> surface, but I'm not sure this meaningfully changes that.
>
> Thanks for the feedback so far!
>
> @echristo Do you still have concerns with this specific change after my
> updated summary?
>

I mean, yes, but I'm also happy to be outvoted here :)

Thanks for all of the discussion, it's really appreciated!

-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220310/d9a1c571/attachment.html>