[PATCH] D120455: [CommandLine] Remove `may only occur zero or one times!` error

Wed Mar 9 21:25:20 PST 2022

MaskRay added a comment.

In D120455#3355507 <https://reviews.llvm.org/D120455#3355507>, @ab wrote:

> In D120455#3352886 <https://reviews.llvm.org/D120455#3352886>, @dexonsmith wrote:
>
>> I don't have a strong opinion; IMO `-mllvm` options shouldn't get used (except by compiler developers) since they're unstable, although I'm sure they get used a little anyway. IMO, if this makes it easier for the intended users (compiler developers) then there isn't a real downside to it.
>>
>> @ab @t.p.northover @Gerolf , any thoughts from you?
>
> Yeah, this seems reasonable, but no strong opinions either.  I totally empathize with the concerns, and ideally we wouldn't have all this exposed surface, but I'm not sure this meaningfully changes that.

Thanks for the feedback so far!

@echristo Do you still have concerns with this specific change after my updated summary?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120455/new/

https://reviews.llvm.org/D120455