[PATCH] D120168: [Debuginfo][LSR] Add support for salvaging variadic dbg.value intrinsics [1/2]

Wed Mar 9 13:40:34 PST 2022

chrisjackson added a comment.

In D120168#3367442 <https://reviews.llvm.org/D120168#3367442>, @Orlando wrote:

> In D120168#3363746 <https://reviews.llvm.org/D120168#3363746>, @chrisjackson wrote:
>
>> Reinstate the check for dbg.value that LSR has changed from single location-op to multi location-op. When LSR makes this change, the single location argument is changed to a DIArglist.  This patch now replaces the DIArglist with a single 'undef'. This will prevent the generation of invalid dbg.value that were causing the crash as reported by @Orlando .
>
> If that change makes the patch not-NFC, please could you add a test for this and mention it in the commit message? Lastly, please can you appease the clang-format bot?

Thinking about it, the codeblock in which this improvement exists is removed entirely in patch [2/2]. So I will revert to the old method of simply giving up on the salvage if the undef location is now nullptr (and thus the type is unavailable) . This will reinstate the NFC status of this patch.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120168/new/

https://reviews.llvm.org/D120168