[PATCH] D120168: [Debuginfo][LSR] Add support for salvaging variadic dbg.value intrinsics [1/2]

Orlando Cazalet-Hyams via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 8 09:09:18 PST 2022


Orlando added a comment.

In D120168#3363746 <https://reviews.llvm.org/D120168#3363746>, @chrisjackson wrote:

> Reinstate the check for dbg.value that LSR has changed from single location-op to multi location-op. When LSR makes this change, the single location argument is changed to a DIArglist.  This patch now replaces the DIArglist with a single 'undef'. This will prevent the generation of invalid dbg.value that were causing the crash as reported by @Orlando .

If that change makes the patch not-NFC, please could you add a test for this and mention it in the commit message? Lastly, please can you appease the clang-format bot?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120168/new/

https://reviews.llvm.org/D120168



More information about the llvm-commits mailing list