[PATCH] D121118: [flang] Add OpenMP flag to bbc

Shraiysh via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 8 04:55:53 PST 2022


shraiysh added a comment.

> apart from code duplication there's overlap in functionality (AFAIK, bbc could already be replaced with flang-new).

I like the idea of replacing bbc with flang-new. Once this is done, I don't think we need any other tool (except maybe `fir-opt`). `flang-new` handles F90 <https://reviews.llvm.org/F90> to FIR. `mlir-opt` handles FIR to LLVM IR Dialect. `mlir-translate` handles LLVM IR Dialect to LLVM IR and the rest is handled by `opt` and other LLVM tools. All these could be exposed by `flang-new` so that a user only needs to use `flang-new`. (Not too sure about `fir-opt` but if we can make `flang-new` plug flang optimizations to `mlir-opt` and run them, I don't think we need this either). We just have to expose these tools using `flang-new` properly. (We need to have a definitive discussion about this on discourse someday).

> We've been trying to reduce the code duplication, but upstreaming is higher priority :)

Ofcourse. Honestly, as long as the functionality is exposed, it doesn't matter to me where it is exposed from, given that we are heavily inclined towards retiring `bbc` and `tco` anyways. My intention behind supporting this patch was that until we make the decision about keeping/retiring `bbc`, we can keep improving it by treating it as a regular tool (without the bias that it is dying 😄).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121118/new/

https://reviews.llvm.org/D121118



More information about the llvm-commits mailing list