[PATCH] D121118: [flang] Add OpenMP flag to bbc

Tue Mar 8 02:32:02 PST 2022

awarzynski added a comment.

I'm primarily concerned that we are diverging here from what was discussed extensively in https://reviews.llvm.org/D117781. In particular, this patch introduces extra redundancy that could be avoided (i.e. this functionality is already available in `flang-new`).  I would really prefer to avoid this, but I also appreciate that the key goal right now is to reduce the delta between `fir-dev` and `main`.

If this is to be merged, than @shraiysh's suggestion makes a lot of sense to me. In general, I would like us to get into a habit of testing with all drivers that support a particular functionality. This way the redundancy is obvious and we have a mechanism to prevent the drivers getting out-of-sync.

@clementval I see that you are using `-pft-test` here. AFAIK, there are no other OpenMP tests using PFT and in general dumping PFT has never been requested/required in the context of `flang-new`. I've decided to add it  (see https://reviews.llvm.org/D121198) so that we can focus on the overall design rather than the fine detail.

> Long term - maybe not - does flang-new use bbc internally or is there some code duplication?

`bbc` and `flang-new` are completely separate. We've been trying to reduce the code duplication, but upstreaming is higher priority :) Also, apart from code duplication there's overlap in functionality (AFAIK, `bbc` could already be replaced with `flang-new`).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121118/new/

https://reviews.llvm.org/D121118