[PATCH] D120357: [llvm-nm]add helper function to print out the object file name, archive name, architecture name

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with one question.



================
Comment at: llvm/tools/llvm-nm/llvm-nm.cpp:1774
     if (Nsect == 0)
-      return;
+      return false;
   }
----------------
DiggerLin wrote:
> jhenderson wrote:
> > Are you sure this should be `return false`? (I don't know either way, but we should preserve behaviour).
> the patch almost is NFC patch, I do not think it is a good idea to change the preserve 
>  behaviour.
I said we should preserve behaviour. My question was: does this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120357/new/

https://reviews.llvm.org/D120357