[PATCH] D120357: [llvm-nm]add helper function to print out the object file name, archive name, architecture name
    Digger Lin via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Mon Mar  7 09:45:03 PST 2022
    
    
  
DiggerLin added inline comments.
================
Comment at: llvm/tools/llvm-nm/llvm-nm.cpp:1774
     if (Nsect == 0)
-      return;
+      return false;
   }
----------------
jhenderson wrote:
> Are you sure this should be `return false`? (I don't know either way, but we should preserve behaviour).
the patch almost is NFC patch, I do not think it is a good idea to change the preserve 
 behaviour.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120357/new/
https://reviews.llvm.org/D120357
    
    
More information about the llvm-commits
mailing list