[PATCH] D121157: [AMDGPU] always use underlying object in the pointsToConstantMemory

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added a comment.

In D121157#3365603 <https://reviews.llvm.org/D121157#3365603>, @arsenm wrote:

> In D121157#3365577 <https://reviews.llvm.org/D121157#3365577>, @rampitec wrote:
>
>> I see 2 options to fix the bug:
>>
>> 1. Go with this patch potentially checking what getUnderlyingObject brought;
>> 2. Change AMDGPUPromoteKernelArguments to attach noclobber metadata instead of a cast. That promise will hold unlike an invariant.
>
> I think both are necessary, and checking for constant address space at all may be wrong

Ugh. 1) does not really work because of the inttoptr our BE started to produce recently to get to the arguments.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121157/new/

https://reviews.llvm.org/D121157