[PATCH] D121157: [AMDGPU] always use underlying object in the pointsToConstantMemory
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 7 14:35:55 PST 2022
arsenm added a comment.
In D121157#3365577 <https://reviews.llvm.org/D121157#3365577>, @rampitec wrote:
> I see 2 options to fix the bug:
>
> 1. Go with this patch potentially checking what getUnderlyingObject brought;
> 2. Change AMDGPUPromoteKernelArguments to attach noclobber metadata instead of a cast. That promise will hold unlike an invariant.
I think both are necessary, and checking for constant address space at all may be wrong
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121157/new/
https://reviews.llvm.org/D121157
More information about the llvm-commits
mailing list