[PATCH] D117852: [CMake][WinMsvc] Replace MSVC_BASE/WINSDK_BASE with LLVM_WINSYSROOT

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added inline comments.
Herald added a project: All.


================
Comment at: llvm/cmake/platforms/WinMsvc.cmake:266
     --target=${TRIPLE_ARCH}-windows-msvc
     -fms-compatibility-version=19.14
+    -vctoolsversion ${MSVC_VER}
----------------
ychen wrote:
> thakis wrote:
> > Do you want to add `/winsysroot` down here too? Or how is that flag getting added?
> https://github.com/llvm/llvm-project/blob/4cc514579f467db51907567b305f21b0607b27d1/llvm/cmake/modules/HandleLLVMOptions.cmake#L463
Not all parts of LLVM's build call HandleLLVMOptions, e.g. compiler-rt doesn't. We should add the flag explicitly to handle those cases as well (and I don't think having it specified twice should cause any harm). I'll put up a patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117852/new/

https://reviews.llvm.org/D117852