[PATCH] D120909: [AMDGPU] Tweak predicates for image_bvh_intersect_ray instructions

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/MIMGInstructions.td:1090
 
+let OtherPredicates = [HasGFX10_AEncoding] in {
 defm IMAGE_BVH_INTERSECT_RAY       : MIMG_IntersectRay<mimgopc<0xe6>, "image_bvh_intersect_ray", 0, 0>;
----------------
Joe_Nash wrote:
> Do you need to concatenate Predicates set in the enclosing scope? Isn't this overriding let OtherPredicates = [HasImageInsts] ?
> That may not matter in practice if HasGFX10_AEncoding implies HasImageInsts
Yes this relies on HasGFX10_AEncoding being a subset of HasImageInsts. The code just above was already doing this for HasExtendedImageInsts so I thought it was OK like that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120909/new/

https://reviews.llvm.org/D120909