[PATCH] D120909: [AMDGPU] Tweak predicates for image_bvh_intersect_ray instructions
Joe Nash via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 3 08:49:44 PST 2022
Joe_Nash added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/MIMGInstructions.td:1090
+let OtherPredicates = [HasGFX10_AEncoding] in {
defm IMAGE_BVH_INTERSECT_RAY : MIMG_IntersectRay<mimgopc<0xe6>, "image_bvh_intersect_ray", 0, 0>;
----------------
Do you need to concatenate Predicates set in the enclosing scope? Isn't this overriding let OtherPredicates = [HasImageInsts] ?
That may not matter in practice if HasGFX10_AEncoding implies HasImageInsts
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120909/new/
https://reviews.llvm.org/D120909
More information about the llvm-commits
mailing list