[PATCH] D113520: [SROA] Maintain shadow/backing alloca when some slices are noncapturnig read-only calls to allow alloca partitioning/promotion

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri updated this revision to Diff 412688.
lebedev.ri marked an inline comment as done.
lebedev.ri added a comment.

Thanks for taking a look!

In D113520#3356615 <https://reviews.llvm.org/D113520#3356615>, @djtodoro wrote:

> The idea behind this seems very interesting/valuable, thanks for this!
>
> I am wondering if you are able to get some benchmark data (SPEC, or phoronix) for this? IIUC, the code-size will be increased, so is that size reasonable?

I suppose the LICM change, that came after this was initially posted,
has rendered this being less crucial than it would be,
but important nonetheless.

Size-wise, this is actually a win i would say:
https://llvm-compile-time-tracker.com/compare.php?from=a8b4f5bbab62091835205f3d648902432a4a5b58&to=aeae054055b125b011c1122f82c86457e159436f&stat=size-total


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113520/new/

https://reviews.llvm.org/D113520

Files:
  llvm/lib/Transforms/Scalar/SROA.cpp
  llvm/test/Transforms/SROA/non-capturing-call-readonly.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D113520.412688.patch
Type: text/x-patch
Size: 57980 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220303/491e8e9c/attachment.bin>