[PATCH] D113520: [SROA] Maintain shadow/backing alloca when some slices are noncapturnig read-only calls to allow alloca partitioning/promotion

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added a comment.

The idea behind this seems very interesting/valuable, thanks for this!

I am wondering if you are able to get some benchmark data (SPEC, or phoronix) for this? IIUC, the code-size will be increased, so is that size reasonable?



================
Comment at: llvm/lib/Transforms/Scalar/SROA.cpp:3627
+/// which will be kept as an up-to-date backup of the to-be-promoted-alloca's
+/// content, and used in it's place in these non-capturing calls.
+void AllocaSlices::formBackingAlloca(AllocaInst *AllocaToPromote,
----------------
Should we add a TODO here for clarifying that there is a plan to support calls that do modify the alloca's content?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113520/new/

https://reviews.llvm.org/D113520