[PATCH] D120481: [AArch64] Try to re-use extended operand for SETCC with v16i8 operands.

Wed Mar 2 02:43:55 PST 2022

dmgreen added a comment.
Herald added a project: All.

Sorry for the delay. It took a while to find the time to figure out what was wrong, but it turned out that was in the other patch.

The change sounds OK to me, although it might be useful to generalize it to handle more types. This seems like it is useful in a few more cases: https://godbolt.org/z/fo8MMrqrE. I'm not sure if this generalises to not just select uses.

================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:17062
+
+  if (any_of(Op->uses(), [](const SDNode *N) {
+        return N->getOpcode() != ISD::VSELECT ||
----------------
Do you have a test for multiple uses?

================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:18741
     return;
-
   case ISD::CTPOP:
----------------
Whitespace

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120481/new/

https://reviews.llvm.org/D120481