[PATCH] D120800: [MachineSink] Disable if there are any irreducible cycles

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 2 01:26:55 PST 2022


nikic created this revision.
nikic added reviewers: shchenz, qcolombet.
Herald added subscribers: pengfei, hiraditya.
Herald added a project: All.
nikic requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This is an alternative to D120330 <https://reviews.llvm.org/D120330>, which disables MachineSink for functions with irreducible cycles entirely. This avoids both the correctness problem, and ensures we don't perform non-profitable sinks into cycles. At the same time, it may also disable profitable sinks in the same function.


https://reviews.llvm.org/D120800

Files:
  llvm/lib/CodeGen/MachineSink.cpp
  llvm/test/CodeGen/X86/callbr-asm-branch-folding.ll
  llvm/test/CodeGen/X86/pr38795.ll
  llvm/test/CodeGen/X86/pr53990-incorrect-machine-sink.ll
  llvm/test/CodeGen/X86/x86-shrink-wrapping.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D120800.412350.patch
Type: text/x-patch
Size: 13982 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220302/e88925c9/attachment.bin>


More information about the llvm-commits mailing list